feat: follow [email protected] (AudioAsset#loopOffset) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnv
commented
Nov 14, 2023
| } | ||
|
|
There was a problem hiding this comment.
本題2: WebAudioPlugin 側の主な実装です。
xnv
commented
Nov 14, 2023
| } | ||
| } | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
本題1。HTMLAudioPlugin 側の主な実装です。
ShinobuTakahashi
approved these changes
Nov 14, 2023
yu-ogi
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
掲題どおり。引数変更への追従で差分が増えていますが、主な変更は次の二箇所だけです。
version の -beta. に関わる変更はマージ前に削除します。
関連: